DaveDurant

Forum Replies Created

Viewing 4 posts - 1 through 4 (of 4 total)
  • Author
    Posts
  • in reply to: Software bug; how to get rid of initial line? #27734
    DaveDurant
    Participant

    It’s 7.21.0, which I think I got in September or so. I do see Turtle in the code but not in ImageManipulator.

    in reply to: Software bug; how to get rid of initial line? #27724
    DaveDurant
    Participant

    Arg.. Won’t let me edit..

    That last line of code should be..

    		if (!wasTravelling)
    			out.write(command);
    

    It seems to be working fine without that but this is the correct way.

    • This reply was modified 4 years, 4 months ago by DaveDurant.
    in reply to: Software bug; how to get rid of initial line? #27722
    DaveDurant
    Participant

    Related, on Spiral with SpiralToCorners set, a *huge* number of G01 travel moves are generated.

    I think this is a problem in the spiral code math generating a lot of moves off the paper but I didn’t update that. Instead, I changed MakelangeloRobotSettings.java to filter out a series of G01 move commands to only send the last one to the gcode. I’m not sure this is the right place for such a thing – maybe it should go in the FW instead? – but it was easiest and fixes the problem for all styles.

    On the file I’m trying to draw, this removed about 17k lines from the gcode and changed it from 5 hours to just over 1 hour. It hasn’t finished drawing yet but is looking really good so far.

    
    	private boolean wasTravelling;
    	private String lastTravel;
    
    	private void write(Writer out, String command) throws IOException {
    		write (out, command, false);
    	}
    
    	private void write(Writer out, String command, boolean isTravel) throws IOException {
    
    		if (isTravel) {
    			wasTravelling = true;
    			lastTravel = command;
    		}
    		else if (wasTravelling) {
    			if (lastTravel != null)
    				out.write(lastTravel);
    
    			wasTravelling = false;
    			lastTravel = null;
    		}
    
    		if (!isTravel)
    			out.write(command);
    	}
    

    edit: wait.. that last if can’t be write.. ?

    That plus changing all the lines that say “out.write(” to be “write(out,” and writeMoveTo to include isUp.

    • This reply was modified 4 years, 4 months ago by DaveDurant.
    in reply to: SVG/DXF line size? or maybe fill? #27520
    DaveDurant
    Participant

    Ok. Thanks for the quick reply!

Viewing 4 posts - 1 through 4 (of 4 total)